Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CrossOver support on Linux #1404

Merged
merged 2 commits into from
Jun 12, 2022

Conversation

CommandMC
Copy link
Collaborator

This wasn't working, it made the code unnecessarily complex, and I don't think anyone ever used it.

The usual settings issues are present (namely, if someone used CX and doesn't change the version to something else, the old settings stay and things will go wrong). Guess this'll get better after the settings refactor


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima changed the base branch from main to beta May 31, 2022 15:46
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@flavioislima flavioislima merged commit 616962b into Heroic-Games-Launcher:beta Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants