Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Missing Percent on download + fuzzy search #1426

Merged
merged 4 commits into from
Jun 2, 2022

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented Jun 2, 2022

When I fixed the issue with the dialog breaking on continuing downloads, I introduced this other bug.
Basically was returning the wrong variable for new downloads.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

Copy link
Member

@imLinguin imLinguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we really need to extend time we spend on testing in the future

@flavioislima flavioislima linked an issue Jun 2, 2022 that may be closed by this pull request
@flavioislima flavioislima changed the title [Fix] Not showing the percentage on new downloads [Fix] Missing Percent on download + fuzzy search Jun 2, 2022
@flavioislima
Copy link
Member Author

Looks good, we really need to extend time we spend on testing in the future

Yes, ideally we should have peer testing as well. When we are coding we focus on that and forget to test everything.
But in this case, I tested a lot but probably did that last change and didn't test again.

@flavioislima flavioislima merged commit 6d8c5f2 into main Jun 2, 2022
@flavioislima flavioislima deleted the fix/get_correct_percentage branch June 2, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants