Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable controller on boot #1438

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Disable controller on boot #1438

merged 1 commit into from
Jun 10, 2022

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jun 5, 2022

This PR fixes #1437 . The configuration value was not being read at boot.

I also tweaked the treshold used to detect sticks being moved, it was too sensitive and a small drift or move by mistake was triggering the actions.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jun 5, 2022
@arielj arielj changed the base branch from main to beta June 5, 2022 19:56
@arielj arielj force-pushed the fixes/disable-controller-on-boot branch from bc99b4a to e3e08f2 Compare June 6, 2022 22:50
@arielj arielj changed the base branch from beta to main June 6, 2022 22:50
flavioislima
flavioislima approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@arielj arielj merged commit ba2fa9d into main Jun 10, 2022
@arielj arielj deleted the fixes/disable-controller-on-boot branch June 10, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'Disable Heroic navigation using controller' doesn't work after restart
2 participants
@arielj @flavioislima