New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detection of search bar focus to open virtual keyboard #1450

Merged

arielj merged 1 commit into main from fixes/virtualkeyboard

Jun 10, 2022

Collaborator

arielj commented Jun 8, 2022

This PR fixes the detection of the searchbar to know if the virtual keyboard should be open when using gamepad navigation.

Added a comment in the search component to prevent this from happening again since it depends on the element's id.

Use the following Checklist if you have changed something on the Backend or Frontend:

Tested the feature and it's working on a current and clean install.
Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
Created / Updated Tests (If necessary)
Created / Updated documentation (If necessary)


          Fix detection of search bar focus

0f861d0

arielj added the pr:ready-for-review label

flavioislima approved these changes

View reviewed changes

Member

flavioislima left a comment

pretty good 👍🏽

arielj merged commit c95a6cd into main

arielj deleted the fixes/virtualkeyboard branch

June 10, 2022 22:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ready-for-review