[Fix] Some things missed in the EOS Overlay PR

[CommandMC]

• We no longer try to get the latest overlay version if the overlay isn't installed & overlay_version.json isn't present (Legendary only creates overlay_version.json if the overlay is installed)
• After installing the overlay on Windows, the Enable button will now correctly show Disable (as the overlay is automatically enabled on Windows)
• When enabling the overlay on Linux without the Wineprefix being present, the Wineprefix will now get created
• Some code cleanup

---

Use the following Checklist if you have changed something on the Backend or Frontend:

• Tested the feature and it's working on a current and clean install.
• Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
• Created / Updated Tests (If necessary)
• Created / Updated documentation (If necessary)

[CommandMC]

src/screens/Settings/components/AdvancedSettings/index.tsx still invokes the isEosOverlayEnabled IPC call with one empty string (only on Windows, so it doesn't cause any issues, but it's still a little misleading IMO)

[Nocccer]

es the isEosOverlayEnabled with one empty

Wait a minute. I didn't know that is also in advancded settings? Can we only put it in one of the section for now?
I don't mind if we put it in gameSubMenu or Advancded page. For me it makes sense, in the advancded options part.

[CommandMC]

The advanced settings is where the main "control panel" is, where you can check for overlay updates, install/uninstall the overlay, and (on Windows) enable/disable it globally. You can only en-/disable it globally on Windows, so having a game-specific setting/button doesn't make sense. That's why it's there on Windows, and in the Tools page on Linux

[Nocccer]

Ok make sense. From my side this whole thing needs more time and clean up. Better frontend handling (component).
We need a proper design how we wanna provide this to the user.

dxvk and vdk3d are for example downloaded on startup in the background if i'm correct. why not downloading eos_overlay on startup and add a checkbox to settings for eos like dxvk?

[CommandMC]

dxvk and vdk3d are for example downloaded on startup in the background if i'm correct. why not downloading eos_overlay on startup and add a checkbox to settings for eos like dxvk?

One simple issue: DXVK and VKD3D are 8 and 2 MB in size respectively. The overlay is ~330MB. We don't just want to reserve 1/3rd of a GB of Hard Drive space for a feature the user might never use/want

[CommandMC]

As for

From my side this whole thing needs more time and clean up. Better frontend handling (component).

Yes, definitely. I just wanted an initial implementation that's usable, so I don't have to run users through the song-and-dance of running Legendary manually (and don't even get me started on Flatpak permission issues)

[Nocccer]

dxvk and vdk3d are for example downloaded on startup in the background if i'm correct. why not downloading eos_overlay on startup and add a checkbox to settings for eos like dxvk?

One simple issue: DXVK and VKD3D are 8 and 2 MB in size respectively. The overlay is ~330MB. We don't just want to reserve 1/3rd of a GB of Hard Drive space for a feature the user might never use/want

Also true. Still i think as ariel pointed out, we can bundle all the frontend stuff into one component. Maybe in another PR?
We can also provide a way to update eos automatically in the future.

So would say this is then a good usable starting point and we can final test/review it.

[Nocccer]

I think this stable enough now. Frontend can be imrpoved in another PR.

[flavioislima]

TEsting here and it has a bug with the SEttings.
If you are on the game settings and click on the Settings button to go to Global settings, the page breaks.
You need to change one line to fix it:

HeroicGamesLauncher/src/screens/Settings/components/GeneralSettings/index.tsx

Line 141 in 13f1f63

value={defaultInstallPath.replaceAll("'", '')}

Change to:
value={defaultInstallPath?.replaceAll("'", '')}

[flavioislima]

Looks good besides the bug I found.

[CommandMC]

This isn't such a simple fix. The whole "General" settings are not loaded when switching from Game Settings -> General Settings.
This was not caused by this PR (I believe it was introduced all the way back in #1464), and it's way out of my league to fix it

[flavioislima]

This isn't such a simple fix. The whole "General" settings are not loaded when switching from Game Settings -> General Settings. This was not caused by this PR (I believe it was introduced all the way back in #1464), and it's way out of my league to fix it

wdym by not loaded? for me they are showing fine.

[Nocccer]

This isn't such a simple fix. The whole "General" settings are not loaded when switching from Game Settings -> General Settings. This was not caused by this PR (I believe it was introduced all the way back in #1464), and it's way out of my league to fix it

wdym by not loaded? for me they are showing fine.

It still breaks on specific tabs, but this happens in beta aswell.
https://user-images.githubusercontent.com/61798668/179235196-3c47b667-4a7f-42a1-88ba-a5ed413dd2b7.mp4

[CommandMC]

wdym by not loaded? for me they are showing fine.

Let me demonstrate: I've enabled "Exit to System Tray" in the Global Settings (and "Default Installation Path" is also set):

When going to the Game Settings -> General Settings, the checkbox isn't checked, default installation path isn't set, and the title still says "Fall Guys":

This error is also printed out when checking the box again:

[Nocccer]

wdym by not loaded? for me they are showing fine.

Let me demonstrate: I've enabled "Exit to System Tray" in the Global Settings (and "Default Installation Path" is also set):

When going to the Game Settings -> General Settings, the checkbox isn't checked, default installation path isn't set, and the title still says "Fall Guys":

This error is also printed out when checking the box again:

Can you check if it still happens on this PR?
#1579