[UI] Fix height of install and settings dialogs #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielj
requested review from
a team,
flavioislima,
CommandMC,
Etaash-mathamsetty,
Nocccer and
imLinguin
and removed request for
a team
arielj
commented
Nov 22, 2023
| @@ -10,3 +10,17 @@ | |||
| width: 100%; | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
the issue was caused by some CSS to make the settings dialog use more height in small screens, I removed some css in the other file and implemented that here we some media queries.
flavioislima
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After one of my last PRs, the install dialog is too tall even when not enough content. This PR fixes that by making the install modal use the height on its content while also letting the settings be bigger to use more height in small screens.
Before:
After:
Use the following Checklist if you have changed something on the Backend or Frontend: