Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] WINEPREFIX ignored when using GPTK #3277

Merged
merged 2 commits into from
Nov 30, 2023
Merged

[Fix] WINEPREFIX ignored when using GPTK #3277

merged 2 commits into from
Nov 30, 2023

Conversation

SB2DD
Copy link
Contributor

@SB2DD SB2DD commented Nov 29, 2023

Just a quick fix to bug #3026. Without this fix, WINEPREFIX isn't set in the environment variables in the launch options, and therefore GPTK uses the user's default wine prefix (in my case ~/.wine). I doubt this fix is crazy perfect, but it's simple and it works!

Tested using Heroic latest on macOS 14.0 with Satisfactory Early Access. (The game is now using the right prefix's save files!)


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@SB2DD
Copy link
Contributor Author

SB2DD commented Nov 29, 2023

Well, I'm confused as to why it's so angry about syntax: the 2 lines right over my commit are quite almost the same...

@SB2DD
Copy link
Contributor Author

SB2DD commented Nov 30, 2023

I think this PR should be ready for review, but I don't have the permissions to do so. (Add the tags and the reviewers)

@arielj
Copy link
Collaborator

arielj commented Nov 30, 2023

one thing I'm worried about this is that if someone has a game already running using the wrong .wine prefix, this will break that because it will set the correct prefix (maybe losing saves for example)

I'm not sure what's the best way to handle that (we should keep the wrong prefix for current installations and have this fix for new installations, but the launch command doesn't know about that)

@SB2DD
Copy link
Contributor Author

SB2DD commented Nov 30, 2023

This would be dirty, but maybe at the next update, on first opening of the launcher, it could force the wine prefix of all GPTK games to the default wine prefix... 🤷‍♂️

@flavioislima
Copy link
Member

This would be dirty, but maybe at the next update, on first opening of the launcher, it could force the wine prefix of all GPTK games to the default wine prefix... 🤷‍♂️

That is not ideal as well since some games might already be working fine on the .wine prefix and also some people might lose their saves. Not lose, they will be there, but 99% of people will think that Heroic has erased them.

So, for now, lets keep as it is and if people come to discord we know how to proper explain the issue to them.

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix ⚔️

@flavioislima flavioislima merged commit f0cd114 into Heroic-Games-Launcher:main Nov 30, 2023
13 checks passed
@SB2DD
Copy link
Contributor Author

SB2DD commented Nov 30, 2023

Nice, happy I could help! I think you could also close #3026, as the issue should now be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants