Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Using crossover with gog and amazon #3308

Merged
merged 3 commits into from
Jan 6, 2024
Merged

[FIX] Using crossover with gog and amazon #3308

merged 3 commits into from
Jan 6, 2024

Conversation

Etaash-mathamsetty
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty commented Dec 10, 2023 •
edited
Loading

Fixes #3118

requires support in gogdl and nile, I don't think either of them has support for crossover :(

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Etaash-mathamsetty Etaash-mathamsetty force-pushed the crossover-fix branch 2 times, most recently from 14ea43e to 829efe3 Compare December 10, 2023 23:55
@Etaash-mathamsetty Etaash-mathamsetty added the pr:ready-for-review Feature-complete, ready for the grind! :P label Dec 21, 2023
@flavioislima flavioislima mentioned this pull request Dec 28, 2023
Closed
flavioislima
flavioislima approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I could not test it. let's hope it fixed the issue.

@arielj arielj merged commit 3193b4c into Heroic-Games-Launcher:main Jan 6, 2024
9 checks passed
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flavioislima flavioislima flavioislima approved these changes

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot start GOG game in CrossOver 23.5
3 participants
@Etaash-mathamsetty @flavioislima @arielj