Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Divide Wine-GE and Wine-GE-LoL in 2 tabs #3327

Merged
merged 2 commits into from
Dec 19, 2023
Merged

[UX] Divide Wine-GE and Wine-GE-LoL in 2 tabs #3327

merged 2 commits into from
Dec 19, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Dec 17, 2023 •
edited
Loading

This PR divides the Wine-GE wines into 2 tabs: Wine-GE and Wine-GE-LoL

It's a really common issue that users install the LoL version by mistake when they want to install the latest wine-ge if the latest one was a LoL release.

This should help prevent that by not listing those in the Wine-GE tab.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team December 17, 2023 22:14
@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Dec 17, 2023
flavioislima
flavioislima approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arielj arielj merged commit ced0c3a into main Dec 19, 2023
9 checks passed
@arielj arielj deleted the wine-ge-lol-tab branch December 19, 2023 00:32
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Etaash-mathamsetty Etaash-mathamsetty Awaiting requested review from Etaash-mathamsetty Etaash-mathamsetty was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielj @flavioislima