Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flatpak] Add some libs missing for native games #3345

Merged
merged 1 commit into from
Jan 1, 2024
Merged

[Flatpak] Add some libs missing for native games #3345

merged 1 commit into from
Jan 1, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Dec 22, 2023 •
edited
Loading

Based on this issue: #1829

And using configuration taken from Lutris: https://github.com/flathub/net.lutris.Lutris/blob/beta/net.lutris.Lutris.yml

I couldn't fine how to install libpng though

I can confirm that Dead Cells native works with the flatpak from this PR

EDIT: PR in flathub's repo flathub/com.heroicgameslauncher.hgl#124

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Dec 22, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team December 22, 2023 23:04
arielj added a commit to arielj/com.heroicgameslauncher.hgl that referenced this pull request Dec 23, 2023
@arielj
Add libcaca, libbsd, and libjpeg
5b4d564 
Using configuration taken from Lutris: https://github.com/flathub/net.lutris.Lutris/blob/beta/net.lutris.Lutris.yml

based on Heroic-Games-Launcher/HeroicGamesLauncher#3345
@arielj arielj mentioned this pull request Dec 23, 2023
Merged
@arielj arielj merged commit dbd1053 into main Jan 1, 2024
9 checks passed
@arielj arielj deleted the flatpak-libs branch January 1, 2024 23:01
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Etaash-mathamsetty Etaash-mathamsetty Awaiting requested review from Etaash-mathamsetty Etaash-mathamsetty was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielj @flavioislima