Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Add Accessibility option to disable closing dialogs when clicking outside #3402

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jan 6, 2024

This PR adds an Accessibility option to let users decide if they want the dialogs to be closed or not when clicking outside.

Clicking outside of dialogs currently (not in main but in the stable release) closes dialogs without any confirmation by the user. This is problematic because clicking outside by mistake can mean information is lost.

Current main branch disables the click outside to close the dialog, but some users might want that to work (it's a common thing to do).

This PR gives the users the option to pick which behavior they want.

One thing I noticed is that disabling the click outside also disables closing dialogs with the Esc key, so I added a handled for that too.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 6, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team January 6, 2024 23:07
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arielj arielj merged commit 7d8f7c9 into main Jan 6, 2024
9 checks passed
@arielj arielj deleted the close-dialog-accessibility branch January 6, 2024 23:32
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants