[UX] Add messages when there are no games to display in the library #3536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielj
requested review from
a team,
flavioislima,
CommandMC,
Etaash-mathamsetty,
Nocccer and
imLinguin
and removed request for
a team
arielj
commented
Feb 8, 2024
| > | ||
| {t('add_game', 'Add Game')} | ||
| </button> | ||
| <AddGameButton /> |
There was a problem hiding this comment.
extracted this into a component to use it in the empty library message
arielj
commented
Feb 8, 2024
| font-size: 2rem; | ||
| max-width: 500px; | ||
| margin: auto; | ||
| padding-bottom: 20%; |
There was a problem hiding this comment.
this message looks odd vertically centered, this padding moves it a bit up
arielj
commented
Feb 8, 2024
| @@ -222,6 +222,10 @@ | |||
| }, | |||
| "title": "Downloads" | |||
| }, | |||
| "emptyLibrary": { | |||
| "noGames": "Your library is empty. You can <1>log in</1> using a store or click <3></3> to add one manually.", | |||
There was a problem hiding this comment.
these <1> and <3> are intentional, the Trans component replaces them with the tags from the children
flavioislima
approved these changes
Feb 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 messages when we have no games to show:
I'm using this
Transelement that supports rendering components and HTML inside it, so thelog inandadd gameelements are interactive in the message. At the same time it provides safety against translations including unwanted HTML since it can only show the HTML we allow (check the translation strings have<1>and<3>, i18next handle that internally, so translators have to use them for elements to render. Then i18next replaces those tags with the ones from the children.Use the following Checklist if you have changed something on the Backend or Frontend: