Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add option to add/edit/delete categories from categories dropdown #3573

Merged
merged 6 commits into from
Mar 31, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Feb 15, 2024

Fixes #3415
Fixes #3406

This PR adds a new dialog to add/edit/delete categories without having to right click a game card.

manage-categories.mp4

Some notes:

  • I ordered the categories alphabetically for now, at some point we can let users reorder them but currently it the order changes when editing which is not good
  • The video was recorded before the last changes so some issue that can be seen in the videos are fixed

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Feb 15, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team February 15, 2024 03:04
@flavioislima
Copy link
Member

Codewise and feature-wise looks good.
But this design I think doesn't work:
image

I think both buttons should be at the same place: bottom.
try something like:
Select ALL
Manage Categories.

I think that would look better.

@arielj
Copy link
Collaborator Author

arielj commented Mar 16, 2024

Codewise and feature-wise looks good. But this design I think doesn't work: image

I think both buttons should be at the same place: bottom. try something like: Select ALL Manage Categories.

I think that would look better.

just pushed this change

@flavioislima
Copy link
Member

Tested here and looks good, will merge to add to the next release.

One minor improvement for the future though: When clicking on Select All it also selects the 'Uncategorized' this has the same effect as selecting none.

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flavioislima flavioislima merged commit cc14ab9 into main Mar 31, 2024
9 checks passed
@flavioislima flavioislima deleted the categories-management branch March 31, 2024 21:19
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to rename category Add the ability to add new categories from the "Categories" dropdown
2 participants