Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Adtraction fallback #3575

Merged
merged 5 commits into from
Mar 9, 2024
Merged

[FIX] Adtraction fallback #3575

merged 5 commits into from
Mar 9, 2024

Conversation

imLinguin
Copy link
Member

When user has blocked the adtraction we should fallback to load gog url directly
I also changed types to Electron.WebviewTag in places where webview was used, to avoid types issues in the future.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Feb 15, 2024
@imLinguin imLinguin requested review from a team, arielj, flavioislima, CommandMC, Etaash-mathamsetty and Nocccer and removed request for a team February 15, 2024 15:31
@imLinguin imLinguin linked an issue Feb 15, 2024 that may be closed by this pull request
Cannot open a store page after logging in. #3569
Closed
arielj
arielj approved these changes Feb 17, 2024
View reviewed changes
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@imLinguin
Copy link
Member Author

Here's how the warning looks like
obraz

flavioislima
flavioislima approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@flavioislima flavioislima merged commit 599fd51 into main Mar 9, 2024
9 checks passed
@flavioislima flavioislima deleted the adtraction-fallback branch March 9, 2024 20:37
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Etaash-mathamsetty Etaash-mathamsetty Awaiting requested review from Etaash-mathamsetty Etaash-mathamsetty was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@arielj arielj Awaiting requested review from arielj

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot open a store page after logging in.
3 participants
@imLinguin @arielj @flavioislima