Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mac msync #3630

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Mac msync #3630

merged 4 commits into from
Mar 21, 2024

Conversation

Mariaboni
Copy link
Contributor

Hey, guys! I implemented Msync (here it is the issue #3315) but I cannot test it, since I don't have a Mac. I was able to check that the Enable Msync option was working fine on the Game Settings
screenshotMsync

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

flavioislima
flavioislima reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but left a few comments.
I can test it on macOS.

src/frontend/screens/Settings/sections/GamesSettings/index.tsx Outdated Show resolved Hide resolved
src/frontend/screens/Settings/components/EnableMsync.tsx Outdated Show resolved Hide resolved
@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 15, 2024
flavioislima
flavioislima approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks for implementing that :D

@flavioislima flavioislima merged commit e374731 into Heroic-Games-Launcher:main Mar 21, 2024
8 of 9 checks passed
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Etaash-mathamsetty Etaash-mathamsetty Etaash-mathamsetty left review comments

@CommandMC CommandMC CommandMC left review comments

@flavioislima flavioislima flavioislima approved these changes

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mariaboni @flavioislima @CommandMC @Etaash-mathamsetty