[Fix] Sideload: Don't update game settings if we're in editMode #3848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking "Finish" in the "Edit App/Game" dialog made Heroic "forget" the Wine Version associated with that game. That's now fixed.
The problem here is that the configured Wine version is initially undefined, only being updated by the version selector. That's not rendered in editMode, so we're just always saving undefined.
It seems this issue was thought about for the Wine prefix, as it is set by an effect above (so the whole spiel ends up doing nothing). This is no longer needed now, so I've removed that part of the effect's functionality.
To test: Edit a sideloaded game (making sure to click "Finish" to save your changes), head to the game settings. Before, notice your Wine Version being reset to the first one in the list. Now, notice your Wine Version is not altered.
Note: The configured CrossOver bottle should also be affected by this change, although I don't have an Apple device to test this on.
Use the following Checklist if you have changed something on the Backend or Frontend: