Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Sideload: Don't update game settings if we're in editMode #3848

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

CommandMC
Copy link
Collaborator

Clicking "Finish" in the "Edit App/Game" dialog made Heroic "forget" the Wine Version associated with that game. That's now fixed.

The problem here is that the configured Wine version is initially undefined, only being updated by the version selector. That's not rendered in editMode, so we're just always saving undefined.
It seems this issue was thought about for the Wine prefix, as it is set by an effect above (so the whole spiel ends up doing nothing). This is no longer needed now, so I've removed that part of the effect's functionality.

To test: Edit a sideloaded game (making sure to click "Finish" to save your changes), head to the game settings. Before, notice your Wine Version being reset to the first one in the list. Now, notice your Wine Version is not altered.

Note: The configured CrossOver bottle should also be affected by this change, although I don't have an Apple device to test this on.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

EditMode hides the Wine prefix/version / CrossOver bottle selector and also
doesn't set it, so clicking "Finish" resets them to their default values
@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 2, 2024
@CommandMC CommandMC requested a review from a team July 2, 2024 19:32
@CommandMC CommandMC self-assigned this Jul 2, 2024
@CommandMC CommandMC requested review from arielj, flavioislima, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team July 2, 2024 19:32
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, tested it and I can confirm the wine config is not lost

@imLinguin imLinguin added this to the 2.15.0 milestone Jul 12, 2024
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@CommandMC CommandMC merged commit cfbdc4d into main Jul 21, 2024
9 checks passed
@CommandMC CommandMC deleted the fix/sideload-edit-forgets-wine-settings branch July 21, 2024 16:00
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jul 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants