Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat-macOS] Download GPTK from Wine Manager #3868

Merged
merged 6 commits into from
Jul 26, 2024
Merged

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented Jul 18, 2024

This adds Apple's Gaming porting toolkit download support from the Wine Manager.

The GTPK build is hosted by Gcenx on Github and should contain all the necessary file to be able to run the games.

image


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 18, 2024
@flavioislima flavioislima added this to the 2.15.0 milestone Jul 18, 2024
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the removal of wine-staging for mac intentional?

src/backend/config.ts Outdated Show resolved Hide resolved
@flavioislima
Copy link
Member Author

is the removal of wine-staging for mac intentional?

I think it not pretty useful.
GPTK will cover 99% of cases and Wine-Crossover the rest.
Wine-staging is also the raw version I believe without any patches.

Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, can't test this

@Gcenx
Copy link
Contributor

Gcenx commented Jul 23, 2024

Upstream wine-stable, wine-devel & wine-staging packages have a small subset of patches to make them work better on macOS/Rosetta2 with permissions from CodeWeavers.

@flavioislima
Copy link
Member Author

Upstream wine-stable, wine-devel & wine-staging packages have a small subset of patches to make them work better on macOS/Rosetta2 with permissions from CodeWeavers.

Nice to know that, but do you think worth it to have all of them on Heroic as well?
I think GPTK and Wine-Crossover should cover most of the cases, right?

@Gcenx
Copy link
Contributor

Gcenx commented Jul 26, 2024

Upstream wine-stable, wine-devel & wine-staging packages have a small subset of patches to make them work better on macOS/Rosetta2 with permissions from CodeWeavers.

Nice to know that, but do you think worth it to have all of them on Heroic as well? I think GPTK and Wine-Crossover should cover most of the cases, right?

I doubt the usefulness of having upstream packages for this project as it targets gaming, not that they can't run games but they don't contain some of the many useful patches/hacks needed for gaming.

@flavioislima
Copy link
Member Author

Upstream wine-stable, wine-devel & wine-staging packages have a small subset of patches to make them work better on macOS/Rosetta2 with permissions from CodeWeavers.

Nice to know that, but do you think worth it to have all of them on Heroic as well? I think GPTK and Wine-Crossover should cover most of the cases, right?

I doubt the usefulness of having upstream packages for this project as it targets gaming, not that they can't run games but they don't contain some of the many useful patches/hacks needed for gaming.

Yes, that is what I was thinking as well. 👍🏽

@flavioislima flavioislima merged commit cb42c8c into main Jul 26, 2024
9 checks passed
@flavioislima flavioislima deleted the feat/gptk_download branch July 26, 2024 11:38
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants