-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat-macOS] Download GPTK from Wine Manager #3868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the removal of wine-staging for mac intentional?
I think it not pretty useful. |
src/frontend/screens/Settings/components/WineVersionSelector.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Mathis Dröge <mathis.droege@ewe.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, can't test this
Upstream wine-stable, wine-devel & wine-staging packages have a small subset of patches to make them work better on macOS/Rosetta2 with permissions from CodeWeavers. |
Nice to know that, but do you think worth it to have all of them on Heroic as well? |
I doubt the usefulness of having upstream packages for this project as it targets gaming, not that they can't run games but they don't contain some of the many useful patches/hacks needed for gaming. |
Yes, that is what I was thinking as well. 👍🏽 |
This adds Apple's Gaming porting toolkit download support from the Wine Manager.
The GTPK build is hosted by Gcenx on Github and should contain all the necessary file to be able to run the games.
Use the following Checklist if you have changed something on the Backend or Frontend: