Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Log the full error in the uncaughtException handler #3904

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

CommandMC
Copy link
Collaborator

logError can handle Error objects just fine, and will give us more information than just the name & message (which can be crucial to debug exceptions caught by this handler)

No need to review this before the release, mainly just creating this to help users with unexplained uncaught exceptions


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Aug 6, 2024
@CommandMC CommandMC self-assigned this Aug 6, 2024
@flavioislima flavioislima merged commit 8652fb9 into main Aug 9, 2024
9 checks passed
@flavioislima flavioislima deleted the fix/log-full-error branch August 9, 2024 16:12
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants