Render SelectFields as MUI Selects #4059
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommandMC
force-pushed
the
feat/web-dropdowns
branch
from
253e014
to
7746476
Compare
This renders most drop-down selection prompts inside Heroic. In turn, these dropdowns now work inside the Gamescope session. Current issues: - Controller navigation does not work, hitting "Down" opens the dropdown, with no way to navigate further down to other components - There is a black box in the top-left of the component, where the label should be
MUI CSS class names are not stable, they cannot be used like this
I prefer to use this over CSS rules in a separate file since it can sometimes be unclear where "the magic happens". Having layout and style together is clearer IMO
This will definitely break things, but it makes selects work
Navigating "over" selects now works This is done by simulating Tab/Shift-Tab key presses when pressing the respective buttons while focussing a MUI select element I've gone ahead and removed our home-grown `GamepadInputEvent` type, as it's just a lesser version of Electron's input events
This makes dialogs closeable with the back button again
Restoring the focussed element on dialog close is already handled by MUI, we don't need this code ourselves Moving focus on dialog open *should* work automatically as well, however it doesn't. I've tried various methods with element properties and JS, nothing seems to work. As a band-aid fix for now, we simulate 1-2 tab presses to focus the dialog content
CommandMC
force-pushed
the
feat/web-dropdowns
branch
from
218a328
to
e88d290
Compare
Closing selects with the B/Circle button
MUI treats an empty value as "don't show anything selected", while native selects show the first option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renders most drop-down selection prompts inside Heroic. In turn, these dropdowns now work inside the Gamescope session.
Current issues:
Use the following Checklist if you have changed something on the Backend or Frontend: