Support adding desktop and start menu shortcuts on windows #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielj
commented
Oct 31, 2021
| const shortcutOptions = { | ||
| target: launchWithProtocol, | ||
| icon: `${gameInfo.install.install_path}\\${gameInfo.install.executable}`, | ||
| iconIndex: 0 |
There was a problem hiding this comment.
the icon must be either from a DLL, the game exe file, or a .ico file, I couldn't use the same getIcon function used for linux
arielj
commented
Oct 31, 2021
| } | ||
| case 'win32': { | ||
| desktopFile = `${app.getPath('desktop')}\\${gameTitle}.lnk` | ||
| menuFile = `${app.getPath('appData')}\\Microsoft\\Windows\\Start Menu\\Programs\\${gameTitle}.lnk` |
There was a problem hiding this comment.
Even though in spanish the Start menu is Menú Inicio, both Start Menu and Menú Inicio work, Windows understands Start Menu and Programs independent of the current system language
|
Let me know when this is ready for review 👍🏽 |
|
hey @flavioislima this is ready for review! |
flavioislima
approved these changes
Nov 4, 2021
|
yes! I tested it in windows 10 and linux mint, adding shortcuts manually and uninstalling games after and things are added and removed correctly I'm happy if anybody wants to test it though, I'm not really sure how to add an automated test for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<--- Put the description here --->
This PR implements the functionality of adding shortcut icons on Windows when the user clicks the
Add shortcutaction in the game page.It also implements removing the shortcuts when the game is uninstalled.
I tried to make the
Add desktop shortcuts automaticallyandAdd games to start menu automaticallysettings work but there's some issue on Windows with the install callback that is not fired properly and it was getting too complicated to do both things on 1 PR so I decided to leave that for another moment.I'm not really sure how to add tests for this since it's too tied to the system.
Closes #724
Use the following Checklist if you have changed something on the Backend or Frontend: