Fixed typo with Discord RPC indicating macOS is "MacOS" when it should be "macOS" #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -536,7 +536,7 @@ Categories=Game; | |||
| os = 'Windows' | |||
| break | |||
| case 'darwin': | |||
| os = 'MacOS' | |||
There was a problem hiding this comment.
Perhaps should be MacOSX then?
There was a problem hiding this comment.
Apple's official term for their desktop operating system is now macOS, regardless of if it was previously named OS X or Mac OS X.
For example: this documentation
flavioislima
approved these changes
Dec 30, 2021
flavioislima
added a commit
that referenced
this pull request
Jan 11, 2022
* rule does not exist * improve webview responsiveness * completely block webview until state change * correct loginurl case removeEventListener ditto * Fix Creating Game Shortcuts on Linux * Fix Check for System Requirements #831 * Add MAC to CI build on Main * fixed discord RPC indicating macOS was "MacOS" (wrong capitalization use) (#837) * apply for all urls * resolve git conflict (hopefully) * fix case for login. also removes some imports. * forgorr to remove log :| * Update translation files Updated by "Squash Git commits" hook in Weblate. Update translation files Updated by "Squash Git commits" hook in Weblate. Co-authored-by: Hosted Weblate <hosted@weblate.org> Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/gamepage/ Translate-URL: https://hosted.weblate.org/projects/heroic-games-launcher/globals/ Translation: Heroic Games Launcher/GamePage Translation: Heroic Games Launcher/Globals * [General] Add Login with SID as alternative to Login with Epic (#875) * chore: wait before getting the sid * feat: add Login with sid as second option * 1i8n: updated keys * Revert "[General] Add Login with SID as alternative to Login with Epic (#875)" This reverts commit 4eefa9a. * Revert "Update translation files" This reverts commit b1dc1bb. * {} curlies after if * realign lock * fix webview URL, swap user agent spoofing to win10 * use did-stop-loading for url * update url to use did-navigate Co-authored-by: Flavio F Lima <flavioislima@gmail.com> Co-authored-by: Andy Lin <60021592+andylin2004@users.noreply.github.com> Co-authored-by: Hosted Weblate <hosted@weblate.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a typo fix with the Discord RPC saying what platform Heroic is running on (from "MacOS" to "macOS")