[General] Refactor and enable spatial navigation #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielj
commented
Jan 4, 2022
| <Library showRecentsOnly library={recentGames} /> | ||
| )} | ||
| <Library library={library} /> | ||
| <div className="listing"> |
There was a problem hiding this comment.
This allows me to remove the position: sticky of the header
arielj
commented
Jan 4, 2022
| }} | ||
| className="gameLogo" | ||
| /> | ||
| <img src={imageSrc} className={imgClasses} alt="cover" /> |
There was a problem hiding this comment.
I moved from a span to an img so it handles dimensions with the element, that helps with the dimensions of the wrapper a tag
arielj
commented
Jan 4, 2022
| @@ -4,6 +4,7 @@ | |||
| width: var(--content-width); | |||
| height: 100%; | |||
| position: fixed; | |||
| top: 0px; | |||
There was a problem hiding this comment.
I had to add this fix after adding the .listings wrapper
arielj
commented
Jan 4, 2022
| @@ -48,6 +48,11 @@ | |||
| animation: apparition 0.3s ease-in forwards; | |||
| } | |||
|
|
|||
| .listing { | |||
There was a problem hiding this comment.
this puts the scroll here instead of in the .content element
arielj
commented
Jan 4, 2022
| max-height: 266px; | ||
| min-width: 130px; | ||
| min-height: 173px; | ||
| .gameCard > a { |
There was a problem hiding this comment.
There are many changes in this file, some are new styles, some are just me moving things around so similar elements are together, and are refactors like moving width, min-width and max-width to a widh: clamp(...) property and things like that
flavioislima
approved these changes
Jan 5, 2022
flavioislima
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
enable-spatial-navigationflag so the app can be navigated using the arrow keys so the keyboard accessibility is better (and this may enable the spatial navigation to use with the gamepad). The PR includes some refactoring that fixed the bugs with the browser's native spatial navigation, this way we don't have to use a javascript solution.I had to make some refactoring to fix the spatial navigation:
I'll add some comments in the diff.
I tested moving around the app with the arrow keys, tried installing a game, cancelling the installation, opening a game details and executing a game.
EDIT: since I was already refactoring things on that screen, I did a small refactor to fix the
back to topbutton that got missing and the html was duplicatedUse the following Checklist if you have changed something on the Backend or Frontend: