Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[General] Show log output in Settings --> Log #929

Merged
merged 10 commits into from
Jan 28, 2022
Merged

Conversation

Nocccer
Copy link
Collaborator

@Nocccer Nocccer commented Jan 27, 2022

Because alot of user doesn't know how to run from a terminal or don't know where the logs are stored, i added a settings tab which shows the log output.

  • Heroic logs are shown in the General Settings page.

    • Added buttons to choose between current and last log
    • Current log: image
    • Last log: image
  • Legendary/Wine logs are shown in the Game Settings page.
    e.g.:
    image

  • Error and Warnings are highlighted with color (red, yellow)

  • Added buttons to show current log file in folder or copy log content to clipboard

  • Update material-ui to 5.3 (was renamed to mui)

  • moved everything from logger in new folder logger


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Nocccer Nocccer requested review from a user and flavioislima January 27, 2022 16:50
@Nocccer Nocccer added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 27, 2022
@flavioislima
Copy link
Member

Can the overflow be inside a fixed square with the log?
Perhaps add max-height, or a fixed height to it and then add overflow: auto.

@Nocccer
Copy link
Collaborator Author

Nocccer commented Jan 27, 2022

@flavioislima already working on it. I don't get the scrollbar initial to the bottom. Not that importantn but would be cool if that would work somehow.

@flavioislima
Copy link
Member

This looks good but have you tried it on other platforms? at least on windows?

flavioislima
flavioislima previously approved these changes Jan 28, 2022
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, tested here, and looks good! :D

@Nocccer
Copy link
Collaborator Author

Nocccer commented Jan 28, 2022

@flavioislima i did some quality of life changes and updated material-ui. If you havve time today to review we can release it with the hotfix, else release it later.

@flavioislima
Copy link
Member

I think the icons to open folder and copy could be a transparent button. They do not seem to be aligned in the middle looking at the screenshots.
I think we have a class for transparent one, experiment a little.
Other than that looks good.

@Nocccer
Copy link
Collaborator Author

Nocccer commented Jan 28, 2022

@flavioislima updated ui see pictures above

@Nocccer Nocccer merged commit 229afaf into main Jan 28, 2022
@Nocccer Nocccer deleted the show_log_in_settings branch January 28, 2022 17:01
@Nocccer Nocccer linked an issue Jan 30, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Latest Log" Button Opens the Window Twice
2 participants