Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] Wine manager minor update #938

Merged
merged 14 commits into from
Feb 1, 2022
Merged

[Linux] Wine manager minor update #938

merged 14 commits into from
Feb 1, 2022

Conversation

Nocccer
Copy link
Collaborator

@Nocccer Nocccer commented Jan 30, 2022

  • updated to heroic-wine-downloader 1.2.2

  • Installation is now abortable

  • improved progressbar
    image

  • names of the version are now correct and unzipped in a folder with the same name


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

- update to heroic-wine-downloader 1.2.0
- improved progress output
- installation is now cancelable
@Nocccer Nocccer added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 30, 2022
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just left one small question.

@Nocccer Nocccer changed the title [General] Wine manager minor update [Linux] Wine manager minor update Jan 30, 2022
flavioislima
flavioislima previously approved these changes Feb 1, 2022
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@Nocccer Nocccer merged commit a9f90f1 into main Feb 1, 2022
@Nocccer Nocccer deleted the wine-manager-update branch February 1, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants