[General] Offline mode only toggleable if allowed #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavioislima
approved these changes
Feb 20, 2022
flavioislima
added a commit
that referenced
this pull request
Mar 2, 2022
…me colours (#964) * increase touch targets for checkboxes * increase touch targets for checkboxes * make gamepad control a bit better, QoL and colours returned to previous on refresh and play buttons * navigation optimisations * make wine-mangager dwnld icons orang * fix colour idiosyncrasies and make exit of gameinstall modal a bit bigger * border align and varname notes moved * revert gamepage title colour * [General] Offline mode only toggleable if allowed (#970) * Offline mode only setable if allowed. * i18n and lint Co-authored-by: Flávio F Lima <flavioislima@gmail.com> * [Fix] External urls not opening (#994) * Add installation on MacOS via Homebrew (#992) * increase touch targets for checkboxes * move infobox to var * remove unecessary curlies * improve cursor changes on hover a LOT * prettier linting * #964 (comment) Co-authored-by: Niklas <61798668+Nocccer@users.noreply.github.com> Co-authored-by: Flávio F Lima <flavioislima@gmail.com> Co-authored-by: Paweł Lidwin <62100117+imLinguin@users.noreply.github.com> Co-authored-by: Depal1 <47154119+Depal1@users.noreply.github.com>
imLinguin
added a commit
to imLinguin/HeroicGamesLauncher
that referenced
this pull request
Mar 5, 2022
…me colours (Heroic-Games-Launcher#964) * increase touch targets for checkboxes * increase touch targets for checkboxes * make gamepad control a bit better, QoL and colours returned to previous on refresh and play buttons * navigation optimisations * make wine-mangager dwnld icons orang * fix colour idiosyncrasies and make exit of gameinstall modal a bit bigger * border align and varname notes moved * revert gamepage title colour * [General] Offline mode only toggleable if allowed (Heroic-Games-Launcher#970) * Offline mode only setable if allowed. * i18n and lint Co-authored-by: Flávio F Lima <flavioislima@gmail.com> * [Fix] External urls not opening (Heroic-Games-Launcher#994) * Add installation on MacOS via Homebrew (Heroic-Games-Launcher#992) * increase touch targets for checkboxes * move infobox to var * remove unecessary curlies * improve cursor changes on hover a LOT * prettier linting * Heroic-Games-Launcher#964 (comment) Co-authored-by: Niklas <61798668+Nocccer@users.noreply.github.com> Co-authored-by: Flávio F Lima <flavioislima@gmail.com> Co-authored-by: Paweł Lidwin <62100117+imLinguin@users.noreply.github.com> Co-authored-by: Depal1 <47154119+Depal1@users.noreply.github.com>
imLinguin
added a commit
to imLinguin/HeroicGamesLauncher
that referenced
this pull request
Mar 5, 2022
…me colours (Heroic-Games-Launcher#964) * increase touch targets for checkboxes * increase touch targets for checkboxes * make gamepad control a bit better, QoL and colours returned to previous on refresh and play buttons * navigation optimisations * make wine-mangager dwnld icons orang * fix colour idiosyncrasies and make exit of gameinstall modal a bit bigger * border align and varname notes moved * revert gamepage title colour * [General] Offline mode only toggleable if allowed (Heroic-Games-Launcher#970) * Offline mode only setable if allowed. * i18n and lint Co-authored-by: Flávio F Lima <flavioislima@gmail.com> * [Fix] External urls not opening (Heroic-Games-Launcher#994) * Add installation on MacOS via Homebrew (Heroic-Games-Launcher#992) * increase touch targets for checkboxes * move infobox to var * remove unecessary curlies * improve cursor changes on hover a LOT * prettier linting * Heroic-Games-Launcher#964 (comment) Co-authored-by: Niklas <61798668+Nocccer@users.noreply.github.com> Co-authored-by: Flávio F Lima <flavioislima@gmail.com> Co-authored-by: Paweł Lidwin <62100117+imLinguin@users.noreply.github.com> Co-authored-by: Depal1 <47154119+Depal1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the offline mode option is still present also if the game needs a internet connection.
It seems that some games still need internet, also if they are marked as offline game.
But this is not a heroic issue.
Use the following Checklist if you have changed something on the Backend or Frontend: