Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fix creation of log file #979

Merged
merged 1 commit into from
Feb 17, 2022
Merged

[Windows] Fix creation of log file #979

merged 1 commit into from
Feb 17, 2022

Conversation

Nocccer
Copy link
Collaborator

@Nocccer Nocccer commented Feb 17, 2022

  • Replaced not allowed characters ( ':' ) with allowed onces ( '_' ) for file creation on windows.
  • Can someone with windows test it ?

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Nocccer Nocccer added the pr:ready-for-review Feature-complete, ready for the grind! :P label Feb 17, 2022
Copy link
Member

@imLinguin imLinguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems it's working

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@Nocccer Nocccer merged commit d11daa3 into main Feb 17, 2022
@Nocccer Nocccer deleted the win_log_fix branch February 17, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants