Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fixed manifest path creation for egsSync #983

Merged
merged 1 commit into from
Feb 20, 2022

Conversation

Nocccer
Copy link
Collaborator

@Nocccer Nocccer commented Feb 19, 2022

There was a problem, where the creation of folder 'C:/ProgramData/Epic/EpicGamesLauncher/Data/Manifests' failed, because mkdirSync wasn't called with recursive option. With recursive set to true, folder should be created now.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Nocccer Nocccer requested a review from flavioislima February 19, 2022 14:42
@Nocccer Nocccer added the pr:ready-for-review Feature-complete, ready for the grind! :P label Feb 19, 2022
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@flavioislima flavioislima merged commit 02f98d8 into main Feb 20, 2022
@flavioislima flavioislima deleted the windows_fix_egs_sync branch February 20, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants