fix microsoft#11480, disallow delete operator on readonly property or…

… index signature
HerringtonDarkholme · Nov 2, 2016 · 7f25eb6 · 7f25eb6
1 parent 6b94bae
commit 7f25eb6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -13486,6 +13486,9 @@ namespace ts {
 
         function checkDeleteExpression(node: DeleteExpression): Type {
             checkExpression(node.expression);
+            checkReferenceExpression(node.expression,
+                Diagnostics.The_operand_of_a_delete_operator_must_be_a_property_reference,
+                Diagnostics.The_operand_of_a_delete_operator_cannot_be_a_read_only_property);
             return booleanType;
         }
 

diff --git a/src/compiler/diagnosticMessages.json b/src/compiler/diagnosticMessages.json
@@ -1971,6 +1971,14 @@
         "category": "Error",
         "code": 2697
     },
+    "The operand of a delete operator must be a property reference": {
+        "category": "Error",
+        "code": 2698
+    },
+    "The operand of a delete operator cannot be a read-only property": {
+        "category": "Error",
+        "code": 2699
+    },
 
     "Import declaration '{0}' is using private name '{1}'.": {
         "category": "Error",