Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated parameter shared_param #14

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

YYStreet
Copy link

In the latest version of apex, shared_param is no longer supported as an option.

Error message:

Critical error while running benchmarks (shared_param is no longer supported as an option.  It was misleadingly named from the start.  It turns out overlapping communication with computation should work fine with shared parameters.  If you still wish to delay communication to the end of the backward pass, use delay_allreduce=True|False instead.). See stacktrace below.
Traceback (most recent call last):
  File "dlcookbook-dlbs/python/pytorch_benchmarks/benchmarks.py", line 411, in main
    model_title, times = benchmark(opts)
  File "dlcookbook-dlbs/python/pytorch_benchmarks/benchmarks.py", line 93, in benchmark
    return benchmark_training(model, opts)
  File "dlcookbook-dlbs/python/pytorch_benchmarks/benchmarks.py", line 213, in benchmark_training
    model = DDP(model, shared_param=True)
  File "/opt/conda/lib/python3.6/site-packages/apex-0.1-py3.6.egg/apex/parallel/distributed.py", line 190, in __init__
    raise ValueError("shared_param is no longer supported as an option.  It was misleadingly named from the start.  It turns out overlapping communication with computation should work fine with shared parameters.  If you still wish to delay communication to the end of the backward pass, use delay_allreduce=True|False instead.")

@sergey-serebryakov
Copy link
Contributor

Thanks for reporting this. I'll test it next week.
Sergey.

@sergey-serebryakov sergey-serebryakov self-assigned this Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants