Update "datastore create" default parameters #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuart-mclaren-hpe
force-pushed
the
datastore-default-changes
branch
from
da295e2 to
8d79d30
Compare
eamonnotoole
approved these changes
Nov 11, 2024
AislingHPE
reviewed
Nov 11, 2024
AislingHPE
approved these changes
Nov 11, 2024
Previously the following input was accepted by the server:
```
{
"name": "mclaren-ds19",
"sizeInBytes": 17179869184,
"storageSystemId": "126fd201-9e6e-5e31-9ffb-a766265b1fd3",
"targetHypervisorClusterId": "",
"volumeInfo": {
"deduplication": false,
"encryption": {
"cipher": "None"
},
"qos": {
"iopsLimit": -1,
"mbpsLimit": -1
}
},
"datastoreType": "VMFS"
}
```
But this now triggers an error response:
```
NimbleVolumeInfo.Qos.MbpsLimit is less than minimum value. NimbleVolumeInfo.Qos.IopsLimit is less than minimum value.
```
In particular, providing `-1` to imply default values for limits
no longer seems to work.
Rather than specifying limits in this way, we now remove them
entirely. We also do the same for other parameters (eg encryption) to
pick up default values.
The create datastore POST request body will now look like:
```
{
"name": "datastore-100",
"sizeInBytes": 17179869184,
"storageSystemId": "f9689284-0bbd-5bf1-981f-b9799bbc106c",
"targetHypervisorClusterId": "",
"datastoreType": "VMFS"
}
```
stuart-mclaren-hpe
force-pushed
the
datastore-default-changes
branch
from
8d79d30 to
41e9ccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the following input was accepted by the server:
But this now triggers an error response.
In particular, providing
-1to imply default values for limits no longer seems to work.Rather than specifying limits in this way, we now remove them entirely. We also do the same for other parameters (eg encryption) to pick up default values.
The create datastore POST request body will now look like: