Update task handling of hypervisor cluster create #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuart-mclaren-hpe
force-pushed
the
hypervisor-cluster-task
branch
2 times, most recently
from
676060b to
eb2b51f
Compare
eamonnotoole
previously approved these changes
Nov 14, 2024
Update the polling of a hypervisor cluster create task. In the case of
hypervisor create, the `sourceResourceUri` field in the final task response
points to a `system` and not the hypervisor cluster that has just been created.
(This differs from the task behaviour for datastores.)
Switch to instead extract the hypervisor cluster uuid from the returned task
body's `associatedResources` list. (Note that the `associatedResources` list
for datastores is empty, so we cannot consistently use this approach.)
```
"associatedResources": [
{
"name": "cluster1",
"resourceUri": "/virtualization/v1beta1/hypervisor-clusters/298a299e-78f5-5acb-86ce-4e9fdc290ab7",
"type": "hypervisor-cluster"
}
]
```
This change avoids terraform erroring after a successful hypervisor create.
stuart-mclaren-hpe
force-pushed
the
hypervisor-cluster-task
branch
from
eb2b51f to
7db970b
Compare
eamonnotoole
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the polling of a hypervisor cluster create task. In the case of hypervisor
create, the
sourceResourceUrifield in the final task response points to asystemand not the hypervisor cluster that has just been created. (This differs from the task
behaviour for datastores.)
Switch to instead extract the hypervisor cluster uuid from the returned task body's
associatedResourceslist. (Note that theassociatedResourceslist for datastores isempty, so we cannot consistently use this approach.)
This change avoids terraform erroring after a successful hypervisor create.