Refactored restore resource #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenkateshRavula
requested review from
sijeesh,
AsisBagga,
chebroluharika,
nabhajit-ray and
yuvirani
chebroluharika
approved these changes
Jun 16, 2020
AsisBagga
reviewed
Jun 19, 2020
| def test_restore_should_be_called_once(self, mock_create): | ||
| restore = { | ||
| "uriOfBackupToRestore": "/rest/backups/example_backup_2014-03-06_023131" | ||
| } | ||
| self.resource.restore(restore) | ||
|
|
||
| mock_create.assert_called_once_with(restore, timeout=-1, default_values=self.resource.DEFAULT_VALUES) | ||
| mock_create.assert_called_once_with(restore, timeout=-1) |
There was a problem hiding this comment.
Why arent we using default values here, any reason to it?
There was a problem hiding this comment.
this refactored code is using the new base class (Resource) and in that class we are handling those default_values. So need to pass them in resource library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored restore resource
Issues Resolved
Fixes #23
Check List
$ tox).