Add tests for the other kinds of schema #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AislingHPE
force-pushed
the
test-test-data-2
branch
3 times, most recently
from
41e42c1 to
0a40089
Compare
eamonnotoole
previously approved these changes
Aug 30, 2024
This tests to make sure that the `additionalProperties: false` and `--nullable-all` schemas validate different sets of values to to the ones that are validated by the default `schema.json`. In particular, `schema-nullable-all.json` should (unless disallowed by certain fields such as `enum`) all a file with all variables defined as `null`. `schema-disallow-additional.json` should disallow additional properties, including within nested objects.
AislingHPE
force-pushed
the
test-test-data-2
branch
from
0a40089 to
b603772
Compare
eamonnotoole
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests to make sure that the
additionalProperties: falseand--nullable-allschemas validate different sets of values to to the ones that are validated by the defaultschema.json.In particular,
schema-nullable-all.jsonshould (unless disallowed by certain fields such asenum) all a file with all variables defined asnull.schema-disallow-additional.jsonshould disallow additional properties, including within nested objects.