Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quilt 支持 #4214

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Quilt 支持 #4214

wants to merge 18 commits into from

Conversation

Pigeon0v0
Copy link
Collaborator

@Pigeon0v0 Pigeon0v0 commented Jul 9, 2024

与 NeoForge 类似,本 PR 将基于先前的 Fabric 安装流程,加入针对 Quilt 的支持。
Close #48

效果预览 / Preview

Quilt-1

Quilt-2

Quilt-3

Quilt-4

To-Do List:

  • 在自动安装界面加入 Quilt 选项,并支持显示版本列表
  • Quilt 相关信息获取
  • 版本列表相关处理(版本排序,Quilt 相关信息显示,附加安装选项之间冲突等)
  • Quilt 自动安装
  • Quilt 手动安装界面
  • 相关资源文件(图标等)补充
  • Quilt 整合包安装
  • 其他界面选项和文本补充

Known Issues:

  • 手动安装包图标需要补充

Note: 由于 Quilt 同步 API 的问题,BMCLAPI 暂时无法用于下载 Quilt。

先前的 PR 操作不当关了()

@Pigeon0v0
Copy link
Collaborator Author

@3gf8jv4dv

Please have a test on features related, such as modpack installing, auto installing, etc. Appreciate!

@Pigeon0v0 Pigeon0v0 mentioned this pull request Jul 9, 2024
8 tasks
3gf8jv4dv

This comment was marked as resolved.

@SALTWOOD

This comment was marked as outdated.

@SALTWOOD

This comment was marked as outdated.

fix: 疑似一些正则错误
@3gf8jv4dv

This comment was marked as outdated.

@SALTWOOD

This comment was marked as outdated.

@SALTWOOD

This comment was marked as outdated.

@3gf8jv4dv

This comment was marked as outdated.

@SALTWOOD

This comment was marked as outdated.

@SALTWOOD

This comment was marked as outdated.

@SALTWOOD

This comment was marked as outdated.

@3gf8jv4dv

This comment was marked as outdated.

@Pigeon0v0
Copy link
Collaborator Author

image

手动安装出现错误

这个 BUG 我记得我修了的...

@SALTWOOD
Copy link
Contributor

草,没切分支(

@SALTWOOD
Copy link
Contributor

我在想一个东西……就是说一部分模组在使用QFAPI加QSL的搭配的时候会无法使用,于是就会在QUILT下使用FABRIC API
而理论上quilt作为fabric的一个分支,当然是可以使用fabric API的
所以有没有必要也把fabric API的安装选项显示出来呢

@SALTWOOD
Copy link
Contributor

SALTWOOD commented Jul 10, 2024

并且在同时选择了quilt和optifine之后……
Quilt生效,OptiFine并未生效

@3gf8jv4dv
Copy link
Collaborator

并且在同时选择了quilt和optifine之后……

If OptiFabric does not support running with Quilt, it seems that OptiFine must be disabled after selecting Quilt Loader.

@Pigeon0v0
Copy link
Collaborator Author

需要确认一下 OptiFabric 和 Quilt 的兼容情况

@3gf8jv4dv
Copy link
Collaborator

3gf8jv4dv commented Jul 10, 2024

@SALTWOOD @Pigeon0v0

Chocohead/OptiFabric#847 (comment)
Chocohead/OptiFabric#1116
Chocohead/OptiFabric#988

It seems that there is no support yet.

@SALTWOOD
Copy link
Contributor

那么就只能是先暂时禁用

@SALTWOOD

This comment was marked as duplicate.

@allMagicNB
Copy link
Contributor

allMagicNB commented Jul 11, 2024

我堆了个 Pre-Release Branch 用来合并测试,先看看(

Copy link
Collaborator

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now selecting 1.14 no longer crashes. 👍

No other issues have been found so far. Waiting for others’ opinions.

Copy link
Collaborator

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that if you select 1.14.4 for the first time after opening the launcher, a strange scene will appear in the UI. Or select a version before 1.14.4 and then select 1.14.4 and it will also appear. It will be normal if you select a higher version and then select 1.14.4.

Preview

@Pigeon0v0
Copy link
Collaborator Author

I don't know why it happens...

Wait for LTCatt. I have no computer at my hands right now.

@3gf8jv4dv
Copy link
Collaborator

我在想一个东西……就是说一部分模组在使用QFAPI加QSL的搭配的时候会无法使用,于是就会在QUILT下使用FABRIC API
而理论上quilt作为fabric的一个分支,当然是可以使用fabric API的
所以有没有必要也把fabric API的安装选项显示出来呢

I would like to continue discussing the possibilities of this feature.

Strictly speaking, Quilt is currently a soft-fork of Fabric, without special circumstances, Fabric mods can usually be loaded happily using Quilt. Unlike NeoForge, they became a hard-fork starting in 20.2 and are officially no longer compatible with MinecraftForge.

Conversely, unless some mod uses mechanisms unique to Quilt, it can generally be loaded in both Fabric and Quilt.

Someone raised a similar question a month ago, and the Quilt moderator said that they would not give up compatibility with Fabric in the short term.

Are there any plans about ending compatibility for Fabric? - Quilt / Development - QuiltMC

I think this feature can be implemented. However, considering that Fabric API and QFAPI may cause conflicts, you may wish to refer to HMCL’s approach. In the current HMCL, if you choose either Fabric API or QFAPI/QSL, you are not allowed to choose the other one.

Preview

@Pigeon0v0
Copy link
Collaborator Author

In my opinion, QSL / QFAPI is designed specially for Quilt, and it can replace Fabric API, so I didn't let Fabric API appear after you have selected Quilt.

@hejiehao
Copy link
Contributor

hejiehao commented Jul 15, 2024

In my opinion, QSL / QFAPI is designed specially for Quilt, and it can replace Fabric API, so I didn't let Fabric API appear after you have selected Quilt.

有一些 Minecraft 版本 QFAPI 不支持或者 QFAPI 更新速度较慢,这个时候可以用 Fabric API 来替代

@Pigeon0v0
Copy link
Collaborator Author

有一些 Minecraft 版本 QFAPI 不支持或者更新速度较慢,这个时候可以用 Fabric API 来替代

好的,有空了改(

Pigeon0v0 and others added 2 commits July 19, 2024 14:35
fix: 自动安装选择 1.14.4 时 Quilt 卡片可能显示异常
@Pigeon0v0
Copy link
Collaborator Author

Done in 6d88559.

Now Fabric API is able to be selected with Quilt selected. I've also added a hint when you select both Quilt and Fabric API, but QSL is actually available. If QSL is not available, Fabric API will be selected automatically.

@3gf8jv4dv @hejiehao Have a test and leave comments. :)

Preview

image

image

image

image

Copy link
Collaborator

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has a UI issue, otherwise looks good. (Not sure if it can be fixed)

EDIT: This also happens with Fabric Loader.

Preview

@Pigeon0v0
Copy link
Collaborator Author

I don't know how it happens...

@JingHai-Lingyun
Copy link
Collaborator

button event binding issue?

@3gf8jv4dv
Copy link
Collaborator

Are there plans to implement #1784 in this PR?

@JingHai-Lingyun
Copy link
Collaborator

JingHai-Lingyun commented Aug 9, 2024

I this #1784 need another pr.
Because if it can detect mods in folder(s), ui may has changes.

@LTCatt LTCatt added the 🚫 阻碍者 它导致了其他项无法继续 label Aug 30, 2024
@LTCatt LTCatt added 暂无计划 短期内没有制作该项的计划 and removed 处理中 开发者正在调查或处理该项 🟦 等待 暂不处理,之后再说 labels Sep 24, 2024
@Ad-closeNN Ad-closeNN mentioned this pull request Oct 3, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
· 新功能 暂无计划 短期内没有制作该项的计划 🚫 阻碍者 它导致了其他项无法继续
Projects
None yet
Development

Successfully merging this pull request may close these issues.

支持自动安装与识别 Quilt 版本
8 participants