Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

让工作流编译支持替换 client_id 和 x-api-key #4228

Merged
merged 50 commits into from
Sep 24, 2024

Conversation

allMagicNB
Copy link
Contributor

@allMagicNB allMagicNB commented Jul 11, 2024

替换需要前往 https://github.com/{你的GitHubID}/{你的PCL2Repo的名称}/settings/secrets/actions/new 添加 Secret,分别为 CLIENT_ID (#3940 微软登录所使用的) 和 CURSEFORGE_API_KEY。

@allMagicNB allMagicNB requested a review from LTCatt July 11, 2024 11:59
@LTCatt
Copy link
Member

LTCatt commented Jul 11, 2024

等待 #3940

@LTCatt LTCatt added 处理中 开发者正在调查或处理该项 · 优化 🟦 等待 暂不处理,之后再说 labels Jul 11, 2024
@allMagicNB
Copy link
Contributor Author

等待 #3940

目前直接合并不会出问题,在替换时没找到目标替换不会报错……
总之这个功能应该是越早推出越好。

@allMagicNB
Copy link
Contributor Author

@LTCatt

@JingHai-Lingyun
Copy link
Collaborator

#3940 先,这个功能就算合并了现在也没用

@allMagicNB
Copy link
Contributor Author

#3940 先,这个功能就算合并了现在也没用

对你没用 ≠ 对别人没用

@allMagicNB allMagicNB changed the title 添加 .gitignore & 让工作流编译支持替换 client_id 和 x-api-key 让工作流编译支持替换 client_id 和 x-api-key Jul 11, 2024
@LTCatt
Copy link
Member

LTCatt commented Jul 11, 2024

别急,到时候 #3940 完了这里指不定还得改呢……

@allMagicNB allMagicNB changed the title 让工作流编译支持替换 client_id 和 x-api-key 让工作流编译支持替换 client_id 和 x-api-key,能发布 Release Jul 12, 2024
@allMagicNB
Copy link
Contributor Author

@3gf8jv4dv What does it look like (

Copy link
Collaborator

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried the CurseForge API Key and it worked as expected. I may take advantage of this test #3940 later.

Overall good, but some Warning content will appear when GHA is running. This type of content appears in Create Release and Upload Release Asset

Warning: The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@allMagicNB
Copy link
Contributor Author

Overall good, but some Warning content will appear when GHA is running. This type of content appears in Create Release and Upload Release Asset

Warning: The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Because GitHub no longer maintains the Release repository.I will replace it.

@allMagicNB
Copy link
Contributor Author

将支持替换 CommitHash 并输出到日志开头。

@LTCatt LTCatt added 🟨 中 优先度:中 and removed 🟦 等待 暂不处理,之后再说 labels Sep 21, 2024
.github/workflows/build.yml Outdated Show resolved Hide resolved
@LTCatt LTCatt merged commit 30bc43b into Hex-Dragon:main Sep 24, 2024
2 checks passed
@LTCatt LTCatt added 完成 已被处理,将在下次更新之后生效 and removed 处理中 开发者正在调查或处理该项 labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
· 优化 完成 已被处理,将在下次更新之后生效 🟨 中 优先度:中
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants