Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

支持 unlisted-versions-of-minecraft #4555

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

支持 unlisted-versions-of-minecraft #4555

wants to merge 24 commits into from

Conversation

zkitefly
Copy link
Collaborator

@zkitefly zkitefly commented Aug 20, 2024 •
edited
Loading

Close #3786

_._20240820174311.mp4

@zkitefly zkitefly marked this pull request as draft August 20, 2024 03:41
@zkitefly zkitefly marked this pull request as ready for review August 20, 2024 03:54
@zkitefly @tangge233
Update Plain Craft Launcher 2/Modules/Minecraft/ModMinecraft.vb
e28513a 
Co-authored-by: tangge233 <50769997+tangge233@users.noreply.github.com>
@LTCatt LTCatt added 处理中 开发者正在调查或处理该项 · 优化 🟩 低 优先度：低 labels Aug 20, 2024
@tangge233

This comment was marked as resolved.

Sign in to view
@zkitefly zkitefly marked this pull request as draft August 20, 2024 05:59
@zkitefly
Copy link
Collaborator Author

image 已下载好的版本归类不正确 还有这个 image

image

image

image

版本分类没问题了

@zkitefly zkitefly marked this pull request as ready for review August 20, 2024 08:36
@zkitefly
Copy link
Collaborator Author

image

image

这要解决吗，好像不是本 PR 导致的？

@zkitefly
Uvmc test (#2)
76d0f01 
* Update ModDownload.vb

* Update ModDownload.vb

* Update ModDownload.vb

* Update ModDownload.vb

* Revert "Update ModDownload.vb"

This reverts commit f1f1aa2.

* Revert "Update ModDownload.vb"

This reverts commit 3a7dec9.
@LTCatt LTCatt added 等待提交者 需要提交者补充信息或进行操作 and removed 处理中 开发者正在调查或处理该项 labels Aug 30, 2024
@zkitefly zkitefly requested a review from LTCatt August 31, 2024 00:52
@Pigeon0v0 Pigeon0v0 added 等待确认 已经过社区确认，等待开发者确认 and removed 等待提交者 需要提交者补充信息或进行操作 labels Aug 31, 2024
@LTCatt LTCatt added 处理中 开发者正在调查或处理该项 and removed 等待确认 已经过社区确认，等待开发者确认 labels Aug 31, 2024
@allMagicNB
Copy link
Contributor

image
byd，PR Collection 炸了我还以为是我解决冲突有问题，结果就是这个 PR 导致的

@allMagicNB
Copy link
Contributor

缓存策略的锅，之前来自 PCL CDN 的缓存没删掉，导致直接读了……

zkitefly and others added 2 commits September 21, 2024 11:25
@zkitefly @allMagicNB
Update Plain Craft Launcher 2/Modules/Minecraft/ModDownload.vb
3491e4e 
Co-authored-by: allMagic <116283787+allMagicNB@users.noreply.github.com>
@zkitefly @allMagicNB
Update Plain Craft Launcher 2/Modules/Minecraft/ModDownload.vb
499dba5 
Co-authored-by: allMagic <116283787+allMagicNB@users.noreply.github.com>
@3gf8jv4dv 3gf8jv4dv mentioned this pull request Sep 23, 2024
Open
1 task
@3gf8jv4dv

This comment was marked as outdated.

Sign in to view
3gf8jv4dv
3gf8jv4dv suggested changes Sep 23, 2024
View reviewed changes
Plain Craft Launcher 2/Modules/Minecraft/ModMinecraft.vb
_Version.McName = "Old"
GoTo VersionSearchFinish
End If
If ReleaseTime.Year > 2000 AndAlso (ReleaseTime.Year < 2011 OrElse (ReleaseTime.Year = 2011 AndAlso ReleaseTime.Month < 9) OrElse (ReleaseTime.Year = 2011 AndAlso ReleaseTime.Month = 9 AndAlso ReleaseTime.Day <= 20)) Then ' 2000 年到 2011 年 9 月 20 日之间
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4803 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3gf8jv4dv 3gf8jv4dv 3gf8jv4dv requested changes

@tangge233 tangge233 tangge233 approved these changes

@allMagicNB allMagicNB allMagicNB approved these changes

@Deep-Dark-Forest Deep-Dark-Forest Deep-Dark-Forest approved these changes

@LTCatt LTCatt Awaiting requested review from LTCatt

Assignees
No one assigned
Labels
· 优化 处理中 开发者正在调查或处理该项 🟩 低 优先度：低
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

支持更多远古版 MC 的下载
8 participants
@zkitefly @tangge233 @wuliaodexiaoluo @allMagicNB @3gf8jv4dv @LTCatt @Deep-Dark-Forest @Pigeon0v0