refactor(frontend): category dialog #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yassinedorbozgithub
changed the title
marrouchi
requested review from
IkbelTalebHssan and
abdou6666
and removed request for
abdou6666 and
IkbelTalebHssan
marrouchi
requested changes
Feb 3, 2025
IkbelTalebHssan
approved these changes
Feb 3, 2025
marrouchi
requested changes
Feb 3, 2025
marrouchi
requested changes
Feb 4, 2025
frontend/src/app-components/dialogs/confirm/ConfirmDialogBody.tsx
Outdated
Show resolved
Hide resolved
abdou6666
approved these changes
Feb 4, 2025
marrouchi
requested changes
Feb 4, 2025
frontend/src/app-components/dialogs/confirm/ConfirmDialogBody.tsx
Outdated
Show resolved
Hide resolved
yassinedorbozgithub
force-pushed
the
refactor/category-dialog
branch
from
b7ca620 to
268dd68
Compare
IkbelTalebHssan
approved these changes
Feb 4, 2025
|
small bug the text displayed in the delete confirmation dialog should be plural in case of deletion multiple blocks (in the visual editor) |
Hi @abdou6666, this PR updates will effect only the categories |
abdou6666
approved these changes
Feb 5, 2025
This was referenced Feb 5, 2025
yassinedorbozgithub
added
refactor
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The main motivation is to refactor repetitive code snippets.
Fixes #636
Functional interfaces demo + How to test
Refactor.categories.dialogs.webm
Checklist: