Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(frontend): update translation dialogs #684

Merged
merged 3 commits into from
Feb 5, 2025
Merged

refactor(frontend): update translation dialogs #684

merged 3 commits into from
Feb 5, 2025

Conversation

yassinedorbozgithub
Copy link
Collaborator

Motivation

The main motivation is to refactor the translations code base to use useDialogs hook instead of using useDialog hook.

Fixes #683

Checklist:

  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

@yassinedorbozgithub yassinedorbozgithub added the enhancement New feature or request label Feb 5, 2025
@yassinedorbozgithub yassinedorbozgithub self-assigned this Feb 5, 2025
@yassinedorbozgithub yassinedorbozgithub linked an issue Feb 5, 2025 that may be closed by this pull request
Refactor Translations dialogs (edit, delete) #683
Closed
@yassinedorbozgithub yassinedorbozgithub mentioned this pull request Feb 5, 2025
Open
18 tasks
@yassinedorbozgithub yassinedorbozgithub marked this pull request as draft February 5, 2025 13:38
@yassinedorbozgithub yassinedorbozgithub marked this pull request as ready for review February 5, 2025 14:07
IkbelTalebHssan
IkbelTalebHssan approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@IkbelTalebHssan IkbelTalebHssan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :rocket

@marrouchi marrouchi merged commit 30aa85f into main Feb 5, 2025
5 checks passed
@yassinedorbozgithub yassinedorbozgithub added refactor Restructuring existing source code and removed enhancement New feature or request labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marrouchi marrouchi marrouchi approved these changes

@IkbelTalebHssan IkbelTalebHssan IkbelTalebHssan approved these changes

Assignees

@yassinedorbozgithub yassinedorbozgithub

Labels
refactor Restructuring existing source code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Translations dialogs (edit, delete)
3 participants
@yassinedorbozgithub @marrouchi @IkbelTalebHssan