Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): update contentType dialogs #721

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

yassinedorbozgithub
Copy link
Collaborator

Motivation

The main motivation is to refactor the contentTypes code bases to use useDialogs hook instead of using useDialog hook.

Fixes #720

Checklist:

  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

@yassinedorbozgithub yassinedorbozgithub added the refactor Restructuring existing source code label Feb 7, 2025
@yassinedorbozgithub yassinedorbozgithub self-assigned this Feb 7, 2025
@yassinedorbozgithub yassinedorbozgithub linked an issue Feb 7, 2025 that may be closed by this pull request
Copy link
Collaborator

@IkbelTalebHssan IkbelTalebHssan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
I want to mention that the issue encountered in this PR regarding the reset() is solved 👏 🙌

@yassinedorbozgithub
Copy link
Collaborator Author

Hi @IkbelTalebHssan, it's a good news that the previous issues are resolve 🪄
Thank you for the review 🙏

@marrouchi marrouchi merged commit 4233408 into main Feb 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Restructuring existing source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Content Types dialogs (add, edit, delete)
3 participants