Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed userAgent check for iPad #165

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

hhiptmair
Copy link

No description provided.

@lengstrom
Copy link
Member

userAgent is intentionally desktop for iPad - have you found this to be a problem?

@hhiptmair
Copy link
Author

yep, because instead of listening to touch-events (what you need to play on an iPad), only click-events are registered if non-mobile devices are detected.

@lengstrom
Copy link
Member

Have you actually had this problem? I could have sworn that on my iPad it worked well.

@hhiptmair
Copy link
Author

yes, i tried to play it with Safari on an iPad mini with iOS 9.3.1 and it didn't work there before the fix.

@lengstrom
Copy link
Member

that's interesting, it works for me on iPad mini, i'll look into it.

@hhiptmair
Copy link
Author

do you have the same iOS version running on your iPad?

@lengstrom
Copy link
Member

not sure, I will check after finals end for me on wednesday!

On Fri, May 13, 2016 at 3:16 AM, hhiptmair notifications@github.com wrote:

do you have the same iOS version running on your iPad?


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#165 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants