This repository has been archived by the owner on Apr 13, 2024. It is now read-only.
date: Add some basic tests, and fix a bug #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dang it, I thought timezones might be an issue. More mocking is required... |
This causes dates and times to be calculated in UTC instead of the local timezone. Which will be helpful in making my tests actually work!
This was outputting the entire date with timezone, instead of just the timezone.
Using the chronokinesis library for mocking the date and timezone. All the tests use the `--utc` option so that the output doesn't vary depending on the local system timezone.
AtkinsSJ
force-pushed
the
date-builtin-tests
branch
from
ebbb2a4 to
194adfa
Compare
|
Fixed the timezone output issues. As a bonus, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is using the mockdate package, so that we can forcenew Date()to return a specific value. Otherwise, it would be really unpleasant to try and make these reliable!Now using
chronokinesis. I'm not sure it's actually necessary, but I switched to it as part of trying to make the timezone names consistent, and it seems like it can't hurt. It also has a much cooler name. 😎