Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physical time in IO is incorrect #404

Closed
SeverinDiederichs opened this issue Mar 7, 2021 · 0 comments · Fixed by #482
Closed

Physical time in IO is incorrect #404

SeverinDiederichs opened this issue Mar 7, 2021 · 0 comments · Fixed by #482
Labels
component: diagnostics About any types of diagnostics pipeline Specific to the implementation of the new pipeline

Comments

@SeverinDiederichs
Copy link
Member

In the new pipeline, the physical time in the IO files is not yet set correctly, because the other ranks are not aware of the dt of the other ranks. The dt needs to be communicated, so each rank knows its absolute time, which it should write to file.

This is also a good opportunity for cleaning:
Previously, the beam and the field data were not at the same time, when written to file.

The correct approach would be to: write the beam to file, calculate the fields on the box (which simultaneously pushes the beam to t += dt), and then write the field to file.

@SeverinDiederichs SeverinDiederichs added component: diagnostics About any types of diagnostics pipeline Specific to the implementation of the new pipeline labels Mar 7, 2021
@MaxThevenet MaxThevenet mentioned this issue Mar 9, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: diagnostics About any types of diagnostics pipeline Specific to the implementation of the new pipeline
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant