Fix shift in time between fields and beam in IO #453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step to fix the physical time mentioned in #404.
Previously, the physical time of the beam and the fields was shifted:
For
max_step = 1
, previously, the beam att = 0
was neglected and the fields att=0
were written to iteration 1, as well as the beam att = 1
With this PR, the beam and the fields are correct: For
max_step = 1
, both fields and beams are written to iteration 0 att = 0
and iteration 1 att = t1
.However, this comes with an important difference:
max_step = 1
, now means 2 plasma swipes, one fort = 0
and one fort = t1
.Therefore, the
max_step
was adjusted in the CI tests.const
isconst
)