Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plasma initialization for MR #1018

Merged
merged 6 commits into from
Sep 25, 2023

Conversation

AlexanderSinn
Copy link
Member

@AlexanderSinn AlexanderSinn commented Sep 20, 2023

electrons.ppc = 1 1
electrons.element= electron
electrons.density(x,y,z) = ne

electrons.fine_ppc = 16 16
electrons.fine_patch(x,y) = "(x<1) && (x>-1) && (y<1) && (y>-1)"
electrons.fine_transition_cells = 5

Example going from 1 1 ppc to 100 100 ppc with 5 transition cells, shape factor 2:

Figure 2
Figure 3

And here the particle positions 1 1 ppc to 10 10 ppc
image

MR plasma init.pptx

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

Sorry, something went wrong.

@AlexanderSinn AlexanderSinn added component: plasma About the plasma species mesh refinement anything related to mesh refinement labels Sep 20, 2023
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the PR! From the one test I did, it worked like a charm. Quick question: do you know why the error does not seem symmetric in the second figure of your PR description? Also, see minor suggestion below.

docs/source/run/parameters.rst Outdated Show resolved Hide resolved
@AlexanderSinn
Copy link
Member Author

It goes from low ppc (left) to high ppc (right) so I wouldn’t expect it to be symmetric.

@MaxThevenet MaxThevenet merged commit 9cb8dd5 into Hi-PACE:development Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: plasma About the plasma species mesh refinement anything related to mesh refinement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants