Fix hpmg for some non-ideal resolutions #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderSinn
commented
Feb 14, 2024
Comment on lines
+1165
to
+1172
| // Use numsweeps equal to the box length rounded up to an even number for large boxes | ||
| int numsweeps = std::max(nsweeps, (m_cor[ilev].box().length().max() + 1) / 2 * 2); | ||
| for (int is = 0; is < numsweeps; ++is) { | ||
| gsrb(is, m_domain[ilev], m_cor[ilev].array(), | ||
| m_res[ilev].const_array(), m_acf[ilev].const_array(), dx0, dy0, | ||
| m_system_type); | ||
| } | ||
| } |
There was a problem hiding this comment.
@WeiqunZhang Is it good to do many gauß seidel iterations on the coarsest level in case the domain cannot be coarsened further, or could this introduce a lot of noise?
There was a problem hiding this comment.
Doing more iterations on the coarsest level will not hurt the convergence. It may not help much either if it's not coarse enough, because it's not very effective at reducing the low frequency errors. If this becomes an issue, we could use a Krylov subspace solver instead of GS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there would have been an invalid device memory access in bottomsolve_gpu from
cor[0]. Now, a warning is printed and a different bottomsolve is used that can make the solver converge reasonably quickly if the final MG level has around 100^2 cells or less.constisconst)