Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openPMD crash if beam has no particles #1121

Conversation

AlexanderSinn
Copy link
Member

Previously, if currRecordComp.storeChunk() was called with no particles, one would get:

terminate called after throwing an instance of 'std::runtime_error'
  what():  Chunks cannot be written for a constant RecordComponent.
SIGABRT
See Backtrace.0 file for details
  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@AlexanderSinn AlexanderSinn added bug Something isn't working component: beam About the beam species labels May 21, 2024
@AlexanderSinn AlexanderSinn requested a review from MaxThevenet May 22, 2024 13:25
@MaxThevenet MaxThevenet merged commit 691cf8f into Hi-PACE:development May 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: beam About the beam species
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants