Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable to initialize spatial/temporal/angular chirped laser + CI test #1136
base: development
Are you sure you want to change the base?
Enable to initialize spatial/temporal/angular chirped laser + CI test #1136
Changes from 90 commits
a2ef19c
70c7489
ef1046a
9059a67
9d29777
c5237bc
c0a364a
13745a7
1dd365d
6e87829
c0c4fe6
0bd0667
349435d
27f2255
0aab9f9
fc1c939
8148926
09fe97f
718621b
2a0655a
2e41451
3538fdc
73cb837
4e2697d
d04fb41
01ca26f
9a303bb
5ea5bde
08b79c3
9c6e8a8
32be993
5908980
4df1073
65fc3ce
f908df7
362fb05
81d945f
0dca6bc
e89bba1
5a0f6da
8176a78
18658e4
b9e50f5
406c78a
0d23f97
27cc3e7
dabe389
992cc79
51492ee
820ca99
2c7d30b
554acf4
1b2f2d7
97058f9
bd13b8b
8a689e7
8348420
7fdb761
8d519b5
397496b
27c90ad
aecd9fe
8a0fbac
0016cb4
d1afd49
f167457
0988ea2
d312ed9
b218ca3
2fadc4b
fa87537
d26915c
6d3c8d9
4fb5d86
3cbf88c
a192ad0
7480ee1
520cb9b
7d9d65a
936f455
aa94037
4577367
38c3eac
b671512
c037958
599fae1
0fc4205
f4ee936
233fd36
2203095
ccb07ce
79c7f3a
3eedf09
720a077
fb540f3
97795e0
961f4e1
324f9a0
8eac5fd
78f27bc
6bf42db
8470e92
5881045
db37901
248e903
25630be
16a9e31
d78d093
3bb3ba7
3b9b19e
62d0ee3
ab9a5e1
7b37e55
f11c2bb
c01f483
d7fd8ff
7483140
8e86f77
7c0b78a
53ebf23
34eabc7
9a1aac3
538b79a
d5f1b9a
64cae75
e439902
c861612
7e77299
f94d0f3
49ffe35
e7fdc30
1cf5942
4b137a8
3f5e205
a6598f5
294c638
06b3ea5
30e59c0
7a4c105
0c17d24
03420a5
0afc89d
7cd81f4
5fa7db3
9b421f0
eab515e
6e45dc5
0df4f48
76d402b
29890bd
ac58466
38dbc5b
a880f70
b5015e1
ac709e0
815e663
b70fe7b
aa68948
bf1dae6
90f5506
bd28df6
eee6fba
7032c24
dfca07c
b125be0
b9ac2c8
925fdaf
8395f5b
e9df903
10649f7
d1cb2dc
25da5b6
a300083
332126b
c8c1ded
06a3149
5868db7
d509499
cbc143c
cb02a6f
33e1be5
440e2eb
898ff88
9499527
3b5e418
bce8836
cc30256
06eadd6
ca25ee1
8b62764
473e3ba
f842f5c
e9a863c
eda52e9
9594260
2938830
47c31ec
264431d
c54bad4
4651541
e5eb5f1
44526ae
1b98624
a7ba153
629001d
1f5241e
b43e6e1
2851f9a
9a65bb1
c6f584d
503b8f7
05c82e7
3b6695d
56327e9
cb070e9
4f53a72
e06306c
0e22e18
a1214ce
e345bcf
09b73ac
76b9339
535bb4d
b27d3c1
f6c2299
d8734be
4f92ec5
c61bb36
834aa59
3edda94
138600a
461df6a
92426f7
40a461b
55ccc11
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make the
help
entries consistent in styleThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make
laser.STC_theta_xy = 0
default and not specify it every time.Furthermore, could you run 1 single simulation with all chirps?
Would your post-processing disentangle these separately? That would be neat and quite convincing on the robustness of post-processing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huixingjian. I think you mention that the post-processing currently would not support this, correct? If so, it is alright to keep as is and reconsider once we have a better understanding on this.