Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mini] Fixing typo in notify finish #280

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

SeverinDiederichs
Copy link
Member

@SeverinDiederichs SeverinDiederichs commented Dec 29, 2020

There was a typo in notify finish, which led to the warning
mpool.c:43 UCX WARN object 0x11ba3bc0 was not returned to mpool ucp_requests
because the MPI_Wait call for m_psend_request was not executed. Additionally, the buffer m_psend_buffer was not freed. Not freeing the memory would cause the simulation to segfault for larger runs.
This PR fixes the issue and the problem is not occurring anymore.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@SeverinDiederichs SeverinDiederichs added bug Something isn't working Parallelization Longitudinal and transverse MPI decomposition labels Dec 29, 2020
@MaxThevenet MaxThevenet merged commit 1299c0d into development Jan 4, 2021
@MaxThevenet MaxThevenet deleted the fix_typo_in_notifyfinish branch January 4, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Parallelization Longitudinal and transverse MPI decomposition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants