-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encapsulate field IO, first step to multiple slice IO #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxThevenet
changed the title
[WIP] enable multiple IO slices
Encapsulate field IO, first step to multiple slice IO
Jan 8, 2021
SeverinDiederichs
approved these changes
Jan 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! openPMD works fine, I tested it on GPU, single precision, with xyz, xz, and yz slices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first step to enable multiple IO slices. It removes details about field diagnostics (2D XZ slice or full 3D XYZ array) and puts it in a separate class
FieldDiagnostic
. The main changes are:FieldDiagnostics
was created, that contains the IO data + metadataFields::m_F
is now a DUMMY multifab (data not allocated) only used for its metadata, while it used to be holding the IO.Fields
now has a new memberFieldDiagnostic m_diags
.xz
only toxz
oryz
.input parameters
hipace.output_slice
andhipace.3d_on_host
have been removed. The slice type is now given byAs before, only the central slice is available.
const
isconst
)