Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mini] fix compiler warning for compiling without openPMD #303

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

SeverinDiederichs
Copy link
Member

@SeverinDiederichs SeverinDiederichs commented Jan 10, 2021

in the diagnostics lev is only used for openPMD, but was declared globally, resulting in an unused parameter warning, if compiled without openPMD. lev is now defined in the openPMD only area, fixing the warning.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@SeverinDiederichs SeverinDiederichs added build CMake, compilation, etc. cleaning Code cleaning, avoid duplication, better naming, better style etc. labels Jan 10, 2021
@MaxThevenet MaxThevenet changed the title [mini] fix compiler warning for compiling without openPMD [DO NOT MERGE] [mini] fix compiler warning for compiling without openPMD Jan 11, 2021
@SeverinDiederichs SeverinDiederichs changed the title [DO NOT MERGE] [mini] fix compiler warning for compiling without openPMD [mini] fix compiler warning for compiling without openPMD Jan 12, 2021
@MaxThevenet MaxThevenet merged commit 1b56ee2 into development Jan 12, 2021
@MaxThevenet MaxThevenet deleted the fix_compiler_warning branch January 12, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CMake, compilation, etc. cleaning Code cleaning, avoid duplication, better naming, better style etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants